Bug 1377 - [ANCK 5.10] xfs在进入自旋锁之前添加判断，减少获取锁的次数提升性能
Summary: [ANCK 5.10] xfs在进入自旋锁之前添加判断，减少获取锁的次数提升性能
Status: RESOLVED FIXED
Alias: None
Product: ANCK 5.10 Dev
Classification: ANCK
Component: fs (show other bugs) fs
Version: unspecified
Hardware: All Linux
: P3-Medium S3-normal
Target Milestone: ---
Assignee: Joseph Qi
QA Contact: shuming
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-31 10:08 UTC by kernel
Modified: 2022-08-16 13:58 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kernel uniontech_group 2022-05-31 10:08:53 UTC 
移植上游的补丁到5.10内核，提升Unixbench filecopy的分数
Comment 1 Joseph Qi alibaba_cloud_group 2022-05-31 10:55:35 UTC 
(In reply to kernel from comment #0)
> 移植上游的补丁到5.10内核，提升Unixbench filecopy的分数

麻烦提供下上游补丁的链接
Comment 2 kernel uniontech_group 2022-05-31 13:37:38 UTC 
commit 977ec4ddf0b75b30afa443cf71ae80e20f501b15 upstream.
Comment 3 kernel uniontech_group 2022-05-31 13:38:13 UTC 
(In reply to josephqi from comment #1)
> (In reply to kernel from comment #0)
> > 移植上游的补丁到5.10内核，提升Unixbench filecopy的分数
> 
> 麻烦提供下上游补丁的链接

commit 977ec4ddf0b75b30afa443cf71ae80e20f501b15 upstream.
Comment 4 Joseph Qi alibaba_cloud_group 2022-05-31 15:25:53 UTC 
(In reply to kernel from comment #2)
> commit 977ec4ddf0b75b30afa443cf71ae80e20f501b15 upstream.

Thanks, 尽管 commit log 里面描述为 aio-dio 相关，但看上去跟 buffer write 也有关系。不过该补丁 5.14 才进入主线，code base 跟 5.10 还有较大差异，需要再详细分析下。

你提到提升 unixbench filecopy 分数，这个是有对比测试过吗？或者说，为什么这个 commit 对 filecopy 有优化？
Comment 5 kernel uniontech_group 2022-05-31 15:41:33 UTC 
(In reply to josephqi from comment #4)
> (In reply to kernel from comment #2)
> > commit 977ec4ddf0b75b30afa443cf71ae80e20f501b15 upstream.
> 
> Thanks, 尽管 commit log 里面描述为 aio-dio 相关，但看上去跟 buffer write 也有关系。不过该补丁 5.14
> 才进入主线，code base 跟 5.10 还有较大差异，需要再详细分析下。
> 
> 你提到提升 unixbench filecopy 分数，这个是有对比测试过吗？或者说，为什么这个 commit 对 filecopy 有优化？

这个我对比测试过，有8%左右的提升。然后抓了一下unixbench fstime的火焰图，xfs_file_aio_write_checks这个函数oncpu的时间明显减少。这个补丁确实还需要再做讨论，如果有后续讨论结果麻烦回复一下。
Comment 6 Joseph Qi alibaba_cloud_group 2022-05-31 15:55:07 UTC 
(In reply to kernel from comment #5)
> (In reply to josephqi from comment #4)
> > (In reply to kernel from comment #2)
> > > commit 977ec4ddf0b75b30afa443cf71ae80e20f501b15 upstream.
> > 
> > Thanks, 尽管 commit log 里面描述为 aio-dio 相关，但看上去跟 buffer write 也有关系。不过该补丁 5.14
> > 才进入主线，code base 跟 5.10 还有较大差异，需要再详细分析下。
> > 
> > 你提到提升 unixbench filecopy 分数，这个是有对比测试过吗？或者说，为什么这个 commit 对 filecopy 有优化？
> 
> 这个我对比测试过，有8%左右的提升。然后抓了一下unixbench
> fstime的火焰图，xfs_file_aio_write_checks这个函数oncpu的时间明显减少。
> 这个补丁确实还需要再做讨论，如果有后续讨论结果麻烦回复一下。

好的，我本地确认下
Comment 8 Joseph Qi alibaba_cloud_group 2022-05-31 19:02:22 UTC 
merged