Bug 2186 - Anolis OS 8 kernel-5.10 not support Wireguard
Summary: Anolis OS 8 kernel-5.10 not support Wireguard
Status: RESOLVED FIXED
Alias: None
Product: Anolis OS 8
Classification: Anolis OS
Component: kernel - anck-5.10 (show other bugs) kernel - anck-5.10
Version: 8.6
Hardware: All Linux
: P3-Medium S3-normal
Target Milestone: ---
Assignee: maqiao
QA Contact: shuming
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-15 14:14 UTC by netero
Modified: 2023-01-17 15:03 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description netero 2022-09-15 14:14:49 UTC
Description of problem:

[root@wangxun ~]# cat /boot/config-5.10.134-12.an8.x86_64 |grep WIREGUARD
# CONFIG_WIREGUARD is not set
Comment 2 dust.li alibaba_cloud_group 2022-09-20 08:15:21 UTC
Any reason why we changed the default config settings in this commit ?

https://gitee.com/anolis/cloud-kernel/commit/122b4948a354a8f7eeff2ddd53b0729ff4a2d9d4
Comment 3 maqiao_mq alibaba_cloud_group 2022-09-20 10:19:07 UTC
(In reply to dust.li from comment #2)
> Any reason why we changed the default config settings in this commit ?
> 
> https://gitee.com/anolis/cloud-kernel/commit/
> 122b4948a354a8f7eeff2ddd53b0729ff4a2d9d4


And to enable CONFIG_WIREGUARD, I just need to do following steps:
1. make anolis_defconfig
2. make menuconfig
3. set CONFIG_WIREGUARD to m
4. copy .config back to anolis_defconfig
Ideally, the default config should be unchanged after running `make anolis_defconfig`, but it actually changed.
So I save the changes of step 1 to the first commit, and save the changes of step 3 to the second commit, to make commits more clear
Comment 4 dust.li alibaba_cloud_group 2022-09-20 12:45:09 UTC
(In reply to maqiao_mq from comment #3)
> (In reply to dust.li from comment #2)
> > Any reason why we changed the default config settings in this commit ?
> > 
> > https://gitee.com/anolis/cloud-kernel/commit/
> > 122b4948a354a8f7eeff2ddd53b0729ff4a2d9d4
> 
> 
> And to enable CONFIG_WIREGUARD, I just need to do following steps:
> 1. make anolis_defconfig
> 2. make menuconfig
> 3. set CONFIG_WIREGUARD to m
> 4. copy .config back to anolis_defconfig
> Ideally, the default config should be unchanged after running `make
> anolis_defconfig`, but it actually changed.
> So I save the changes of step 1 to the first commit, and save the changes of
> step 3 to the second commit, to make commits more clear

I saw pretty much configerations were changed with step #1, have you checked whether there are any real changes in step #1 ?
I'm a little worried about the config changes may bring some issues, like performance degradation.

If no real changes take place, its better to add a notation like
"No real function changes" in the commit log. If yes, I also sugguest you to
mark them out in the commit log.
Comment 5 maqiao_mq alibaba_cloud_group 2022-09-20 15:36:17 UTC
(In reply to dust.li from comment #4)
> (In reply to maqiao_mq from comment #3)
> > (In reply to dust.li from comment #2)
> > > Any reason why we changed the default config settings in this commit ?
> > > 
> > > https://gitee.com/anolis/cloud-kernel/commit/
> > > 122b4948a354a8f7eeff2ddd53b0729ff4a2d9d4
> > 
> > 
> > And to enable CONFIG_WIREGUARD, I just need to do following steps:
> > 1. make anolis_defconfig
> > 2. make menuconfig
> > 3. set CONFIG_WIREGUARD to m
> > 4. copy .config back to anolis_defconfig
> > Ideally, the default config should be unchanged after running `make
> > anolis_defconfig`, but it actually changed.
> > So I save the changes of step 1 to the first commit, and save the changes of
> > step 3 to the second commit, to make commits more clear
> 
> I saw pretty much configerations were changed with step #1, have you checked
> whether there are any real changes in step #1 ?
> I'm a little worried about the config changes may bring some issues, like
> performance degradation.
> 
> If no real changes take place, its better to add a notation like
> "No real function changes" in the commit log. If yes, I also sugguest you to
> mark them out in the commit log.

Refresh default config won't bring any performance degradation issues.
When rpmbuild kernel, the configs is processed in following steps:
1. cp anolis_defconfig as .config
2. `make olddefconfig` to refresh .config
3. compile kernel with .config
And I have checked, the result of `make olddefconfig` is same as `make menuconfig` on both x86 and arm64 platform.
Comment 6 dust.li alibaba_cloud_group 2022-09-22 09:51:56 UTC
(In reply to maqiao_mq from comment #5)
> (In reply to dust.li from comment #4)
> > (In reply to maqiao_mq from comment #3)
> > > (In reply to dust.li from comment #2)
> > > > Any reason why we changed the default config settings in this commit ?
> > > > 
> > > > https://gitee.com/anolis/cloud-kernel/commit/
> > > > 122b4948a354a8f7eeff2ddd53b0729ff4a2d9d4
> > > 
> > > 
> > > And to enable CONFIG_WIREGUARD, I just need to do following steps:
> > > 1. make anolis_defconfig
> > > 2. make menuconfig
> > > 3. set CONFIG_WIREGUARD to m
> > > 4. copy .config back to anolis_defconfig
> > > Ideally, the default config should be unchanged after running `make
> > > anolis_defconfig`, but it actually changed.
> > > So I save the changes of step 1 to the first commit, and save the changes of
> > > step 3 to the second commit, to make commits more clear
> > 
> > I saw pretty much configerations were changed with step #1, have you checked
> > whether there are any real changes in step #1 ?
> > I'm a little worried about the config changes may bring some issues, like
> > performance degradation.
> > 
> > If no real changes take place, its better to add a notation like
> > "No real function changes" in the commit log. If yes, I also sugguest you to
> > mark them out in the commit log.
> 
> Refresh default config won't bring any performance degradation issues.
> When rpmbuild kernel, the configs is processed in following steps:
> 1. cp anolis_defconfig as .config
> 2. `make olddefconfig` to refresh .config
> 3. compile kernel with .config
> And I have checked, the result of `make olddefconfig` is same as `make
> menuconfig` on both x86 and arm64 platform.

So you mean there is no real function change to the config, am I right ?
If that is true, please add a note in the commit message, so we won't worry about that.
Comment 7 maqiao_mq alibaba_cloud_group 2022-09-22 09:53:04 UTC
(In reply to dust.li from comment #6)
> (In reply to maqiao_mq from comment #5)
> > (In reply to dust.li from comment #4)
> > > (In reply to maqiao_mq from comment #3)
> > > > (In reply to dust.li from comment #2)
> > > > > Any reason why we changed the default config settings in this commit ?
> > > > > 
> > > > > https://gitee.com/anolis/cloud-kernel/commit/
> > > > > 122b4948a354a8f7eeff2ddd53b0729ff4a2d9d4
> > > > 
> > > > 
> > > > And to enable CONFIG_WIREGUARD, I just need to do following steps:
> > > > 1. make anolis_defconfig
> > > > 2. make menuconfig
> > > > 3. set CONFIG_WIREGUARD to m
> > > > 4. copy .config back to anolis_defconfig
> > > > Ideally, the default config should be unchanged after running `make
> > > > anolis_defconfig`, but it actually changed.
> > > > So I save the changes of step 1 to the first commit, and save the changes of
> > > > step 3 to the second commit, to make commits more clear
> > > 
> > > I saw pretty much configerations were changed with step #1, have you checked
> > > whether there are any real changes in step #1 ?
> > > I'm a little worried about the config changes may bring some issues, like
> > > performance degradation.
> > > 
> > > If no real changes take place, its better to add a notation like
> > > "No real function changes" in the commit log. If yes, I also sugguest you to
> > > mark them out in the commit log.
> > 
> > Refresh default config won't bring any performance degradation issues.
> > When rpmbuild kernel, the configs is processed in following steps:
> > 1. cp anolis_defconfig as .config
> > 2. `make olddefconfig` to refresh .config
> > 3. compile kernel with .config
> > And I have checked, the result of `make olddefconfig` is same as `make
> > menuconfig` on both x86 and arm64 platform.
> 
> So you mean there is no real function change to the config, am I right ?
> If that is true, please add a note in the commit message, so we won't worry
> about that.

Yes, no real function change.
And I've added note in commit log.
Comment 8 maqiao alibaba_cloud_group 2023-01-17 15:03:43 UTC
merged: https://gitee.com/anolis/cloud-kernel/pulls/716