Bug 4126 - drivers/gpu/drm/gma500/cdv_device.c:218 cdv_errata() warn: inconsistent indenting
Summary: drivers/gpu/drm/gma500/cdv_device.c:218 cdv_errata() warn: inconsistent inden...
Status: NEW
Alias: None
Product: Upstream
Classification: Unclassified
Component: drivers (show other bugs) drivers
Version: unspecified
Hardware: All Linux
: P3-Medium S3-normal
Target Milestone: ---
Assignee: abaci-robot
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-21 11:34 UTC by abaci-robot
Modified: 2023-02-21 11:35 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description abaci-robot alibaba_cloud_group 2023-02-21 11:34:55 UTC
drivers/gpu/drm/gma500/cdv_device.c:218 cdv_errata() warn: inconsistent indenting

In the following kernel version:

name: linux-next
url: http://kernel.source.codeaurora.cn/pub/scm/linux/kernel/git/next/linux-next.git
branch: next-20230119
commit: aa5c49149a823599764e6953229b028e4bf6e9cc
Comment 1 abaci-robot alibaba_cloud_group 2023-02-21 11:35:24 UTC
WARNING: Block comments use a trailing */ on a separate line
#81: FILE: drivers/gpu/drm/gma500/cdv_device.c:81:
+                * smash PWM control as firmware will take control of it. */

WARNING: Missing a blank line after declarations
#152: FILE: drivers/gpu/drm/gma500/cdv_device.c:152:
+       struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0);
+       pci_write_config_dword(pci_root, 0xD0, mcr);

WARNING: Missing a blank line after declarations
#163: FILE: drivers/gpu/drm/gma500/cdv_device.c:163:
+       struct pci_dev *pci_root = pci_get_domain_bus_and_slot(domain, 0, 0);
+       pci_write_config_dword(pci_root, 0xD4, value);

WARNING: Missing a blank line after declarations
#199: FILE: drivers/gpu/drm/gma500/cdv_device.c:199:
+               u32 pwr_sts = inl(dev_priv->apm_base + PSB_APM_STS);
+               if ((pwr_sts & PSB_PWRGT_GFX_MASK) == 0)

ERROR: code indent should use tabs where possible
#404: FILE: drivers/gpu/drm/gma500/cdv_device.c:404:
+        struct drm_psb_private *dev_priv = container_of(work, struct drm_psb_private,$

WARNING: please, no spaces at the start of a line
#404: FILE: drivers/gpu/drm/gma500/cdv_device.c:404:
+        struct drm_psb_private *dev_priv = container_of(work, struct drm_psb_private,$

ERROR: code indent should use tabs where possible
#408: FILE: drivers/gpu/drm/gma500/cdv_device.c:408:
+        /* Just fire off a uevent and let userspace tell us what to do */$

ERROR: code indent should use tabs where possible
#409: FILE: drivers/gpu/drm/gma500/cdv_device.c:409:
+        drm_helper_hpd_irq_event(dev);$

WARNING: please, no spaces at the start of a line
#409: FILE: drivers/gpu/drm/gma500/cdv_device.c:409:
+        drm_helper_hpd_irq_event(dev);$

WARNING: Block comments use * on subsequent lines
#413: FILE: drivers/gpu/drm/gma500/cdv_device.c:413:
+/* The core driver has received a hotplug IRQ. We are in IRQ context
+   so extract the needed information and kick off queued processing */

WARNING: Block comments use a trailing */ on a separate line
#413: FILE: drivers/gpu/drm/gma500/cdv_device.c:413:
+   so extract the needed information and kick off queued processing */

WARNING: Missing a blank line after declarations
#418: FILE: drivers/gpu/drm/gma500/cdv_device.c:418:
+       struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
+       schedule_work(&dev_priv->hotplug_work);

WARNING: Missing a blank line after declarations
#427: FILE: drivers/gpu/drm/gma500/cdv_device.c:427:
+               u32 hotplug = REG_READ(PORT_HOTPLUG_EN);
+               hotplug |= HDMIB_HOTPLUG_INT_EN | HDMIC_HOTPLUG_INT_EN |

WARNING: Missing a blank line after declarations
#552: FILE: drivers/gpu/drm/gma500/cdv_device.c:552:
+       struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
+       INIT_WORK(&dev_priv->hotplug_work, cdv_hotplug_work_func);