Bug 4221 - [ANCK 5.10] remove useless new_opts in reiserfs_remount
Summary: [ANCK 5.10] remove useless new_opts in reiserfs_remount
Status: RESOLVED FIXED
Alias: None
Product: ANCK 5.10 Dev
Classification: ANCK
Component: fs (show other bugs) fs
Version: 5.10.y-15
Hardware: All Linux
: P3-Medium S3-normal
Target Milestone: ---
Assignee: xinhaitao
QA Contact: shuming
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-24 15:59 UTC by xinhaitao
Modified: 2023-03-02 18:11 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xinhaitao inspur_group 2023-02-24 15:59:37 UTC 
Description of problem:

Since the commit c3d98ea08291 ("VFS: Don't use save/replace_mount_options
if not using generic_show_options") eliminates replace_mount_options
in reiserfs_remount, but does not handle the allocated new_opts,
it will cause memory leak in the reiserfs_remount.

Because new_opts is useless in reiserfs_mount, so we fix this bug by
removing the useless new_opts in reiserfs_remount.
Comment 2 Joseph Qi alibaba_cloud_group 2023-02-26 20:37:49 UTC 
(In reply to josephqi from comment #1)
> https://gitee.com/anolis/cloud-kernel/pulls/1277

Please add me (gitee josephhz) as the reviewer so that I can merge it.
Comment 3 Joseph Qi alibaba_cloud_group 2023-02-28 15:26:41 UTC 
merged
Comment 4 Joseph Qi alibaba_cloud_group 2023-02-28 15:32:52 UTC 
(In reply to josephqi from comment #3)
> merged