Bug 4345 - [ANCK 4.19] xfs: remove incorrect ASSERT in xfs_rename
Summary: [ANCK 4.19] xfs: remove incorrect ASSERT in xfs_rename
Status: RESOLVED FIXED
Alias: None
Product: ANCK 4.19 Dev
Classification: ANCK
Component: fs (show other bugs) fs
Version: unspecified
Hardware: All Linux
: P3-Medium S3-normal
Target Milestone: ---
Assignee: rafanadal
QA Contact: shuming
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-04 11:21 UTC by rafanadal
Modified: 2023-03-06 10:01 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rafanadal 2023-03-04 11:21:01 UTC 
Description of problem:
This ASSERT in xfs_rename is a) incorrect, because
(RENAME_WHITEOUT|RENAME_NOREPLACE) is a valid combination, and
b) unnecessary, because actual invalid flag combinations are already
handled at the vfs level in do_renameat2() before we get called.
So, remove it.


Additional info:
upstream: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/fs/xfs?h=v5.10.170&id=e14930e9f9c657cf109326752871d3c701b12326
Comment 2 Joseph Qi alibaba_cloud_group 2023-03-06 10:01:44 UTC 
merged