Bug 4482 - [ANCK 5.10] drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init
Summary: [ANCK 5.10] drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shme...
Status: RESOLVED FIXED
Alias: None
Product: ANCK 5.10 Dev
Classification: ANCK
Component: drivers (show other bugs) drivers
Version: 5.10.y-10
Hardware: All Linux
: P3-Medium S3-normal
Target Milestone: ---
Assignee: adam-fxj
QA Contact: shuming
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-10 17:43 UTC by adam-fxj
Modified: 2023-03-10 19:05 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description adam-fxj 2023-03-10 17:43:21 UTC 
Description of problem:


drm/virtio: Fix NULL vs IS_ERR checking in virtio_gpu_object_shmem_init
commit c24968734abfed81c8f93dc5f44a7b7a9aecadfa upstream.

Since drm_prime_pages_to_sg() function return error pointers.
The drm_gem_shmem_get_sg_table() function returns error pointers too.
Using IS_ERR() to check the return value to fix this.

Fixes: 2f2aa13724d5 ("drm/virtio: move virtio_gpu_mem_entry initialization to new function")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220602104223.54527-1-linmq006@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>


Additional info:
upstream:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.10.y&id=0a4181b23acf53e9c95b351df6a7891116b98f9b